[App_rpt] General config questions....try #2...and patch

David McGough kb4fxc at inttek.net
Sat Jul 26 19:46:01 UTC 2008


Okay, here it goes. This is a diff against the original chan_usbradio.c as
installed with the current ACID ISO.

By default, dtmf is always enabled. To disable, add dtmf_disable=0 to the
desired stanza of the usbradio.conf file.

73, David KB4FXC

---------------------------------------------------------------------------

chan_usbradio.c.patch -- output from: diff -Naur
------<cut here>---------------------------------------------------
--- chan_usbradio.c     2008-07-26 12:33:44.000000000 -0700
+++ chan_usbradio.c.new 2008-07-26 12:42:32.000000000 -0700
@@ -489,6 +489,7 @@
        char    debuglevel;
        char    radioduplex;                    //
        char    wanteeprom;
+       char    dtmf_decode_enabled;            // jdm
  
        int     tracetype;
        int     tracelevel;
@@ -634,6 +635,7 @@
        .lastopen = { 0, 0 },
        .boost = BOOST_SCALE,
        .wanteeprom = 1,
+       .dtmf_decode_enabled = 1,       // jdm
        .area = 0,
        .rptnum = 0,
 };
@@ -2083,6 +2085,8 @@
            if ((f1->frametype == AST_FRAME_DTMF_END) ||
              (f1->frametype == AST_FRAME_DTMF_BEGIN))
            {
+             ast_log(LOG_NOTICE,"DTMF enabled: %d\n",o->dtmf_decode_enabled);        // jdm
+             if (o->dtmf_decode_enabled) {
                if ((f1->subclass == 'm') || (f1->subclass == 'u'))
                {
                        f1->frametype = AST_FRAME_NULL;
@@ -2093,6 +2097,7 @@
                        ast_log(LOG_NOTICE,"Got DTMF char %c\n",f1->subclass);
                return(f1);
            }
+         }
        }
        return f;
 }
@@ -3463,6 +3468,7 @@
                        M_F("txtoctype",store_txtoctype(o,(char *)v->value))
                        M_UINT("hdwtype",o->hdwtype)
                        M_UINT("eeprom",o->wanteeprom)
+                       M_BOOL("dtmf_decode",o->dtmf_decode_enabled)            // jdm
                        M_UINT("duplex",o->radioduplex)
                        M_UINT("txsettletime",o->txsettletime)
                        M_BOOL("rxpolarity",o->b.rxpolarity)
------<cut here>---------------------------------------------------

On Sat, 26 Jul 2008, Roger F. Jordan wrote:

> I would be very interested in seeing the patch!  I am impressed with the
> solution!  Good job!
> 
> Roger W4RFJ 
> 
> -----Original Message-----
> From: app_rpt-bounces at lists.illiana.net
> [mailto:app_rpt-bounces at lists.illiana.net] On Behalf Of David McGough
> Sent: Saturday, July 26, 2008 3:03 AM
> To: Asterisk Repeater Controler
> Subject: Re: [App_rpt] General config questions....try #2...and patch
> 
> 
> 
> Hi Jim,
> 
> Upon more review, I decided to add a patch to try to completely turn off
> DTMF decode, if desired. So, I added some test code to the chan_usbaudio.c
> file and a new boolean parameter "dtmf_decode" to the usbradio.conf file.
> 
> With dtmf_decode=0, the audio dropout issue is completely resolved! Now, the
> staticy HF audio sounds GREAT (to me, at least!). No more choppiness...
> 
> I'll be glad to post the patch if you all would like to take a look? It
> doesn't seem to break anything (so far....).
> 
> Thanks for your help!
> 
> 73, David KB4FXC
> 
> 
> 
> On Fri, 25 Jul 2008, David McGough wrote:
> 
> > 
> > Hi Jim,
> > 
> > Yes, I think it's setup okay....The radio is an IC-706mk2g, and it 
> > DOES work. I'm just getting spurious DTMF audio muting when DTMF is 
> > falsely detected. The VERY trimmed-down node stanza is:
> > 
> > [222]                           ;;; IC-706mk2g
> > rxchannel = Radio/usb1
> > remote=ic706
> > duplex=0
> > 
> > 
> > And, the nodes section is:
> > 
> > [nodes]
> > 111 = radio at 127.0.0.1/111,NONE		;; Kenwood TKR-850
> > 222 = radio at 127.0.0.1/222,NONE,y	;; Icom IC-706mk2g
> > 
> > The related chan_usbradio stanza is:
> > 
> > [usb1]
> > hdwtype=0
> > rxboost=0
> > rxctcssrelax=1
> > txctcssdefault=0.0
> > rxctcssfreqs=0.0
> > txctcssfreqs=0.0
> > carrierfrom=usbinvert
> > ctcssfrom=no
> > rxdemod=speaker
> > txprelim=no
> > txtoctype=notone
> > txmixa=voice
> > txmixb=no
> > invertptt=0
> > duplex=0
> > eeprom=0
> > 
> > 
> > Thanks,
> > 
> > David KB4FXC
> > 
> > On Fri, 25 Jul 2008, Jim Duuuude wrote:
> > 
> > > 
> > > first, do you have the thing set up as a remote base?
> > > 
> > > > Date: Fri, 25 Jul 2008 18:56:56 -0400
> > > > From: kb4fxc at inttek.net
> > > > To: app_rpt at lists.illiana.net
> > > > Subject: Re: [App_rpt] General config questions....try #2
> > > > 
> > > > 
> > > > Hi,
> > > > 
> > > > I have already removed the function stanzas and the node config 
> > > > includes a ',y' at the end....But, I still see "Got DTMF char" 
> > > > messages from chan_usbradio in the logs. And, the main thing is 
> > > > there is an associated brief muting of audio when this 
> > > > occurs--which may occur rather frequently, depending on HF noise.
> > > > 
> > > > As for my second original question about a way to easily make a 
> > > > audio file of the CD ID, I found a way to do this using the 
> > > > "tomorse" freeware software. If anyone is interested, I'll post how I
> went about it.
> > > > 
> > > > Thanks,
> > > > 
> > > > David KB4FXC
> > > >  
> > > > 
> > > > 
> > > > 
> > > > 
> > > > On Fri, 25 Jul 2008, Jim Duuuude wrote:
> > > > 
> > > > > 
> > > > > An HF node should be running as a remote base, therefore not 
> > > > > decoding DTMF at all
> > > > > 
> > > > > > From: hwstar at rodgers.sdcoxmail.com
> > > > > > To: app_rpt at lists.illiana.net
> > > > > > Date: Fri, 25 Jul 2008 11:23:32 -0700
> > > > > > Subject: Re: [App_rpt] General config questions....try #2
> > > > > > 
> > > > > > 
> > > > > > Part 1 of the answer:
> > > > > > 
> > > > > > If you are running this as a standard node, you need to 
> > > > > > specify an empty function table stanza so that nothing gets
> decoded. If you are running as a remote base node, then no DTMF functions
> will be decoded fromt he radio interface. Remote base nodes have .y on the
> end of them in the node table. This is how app_rpt knows which type of code
> to run.
> > > > > > 
> > > > > > Part 2 of the answer:
> > > > > > 
> > > > > > chan_usbradio causes DTMF digits to be printed on the console. 
> > > > > > As far as I know, there's no way to disable this without modifying
> the channel driver itself, but maybe Steve Henke knows something I don't.
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > From: David McGough <kb4fxc at inttek.net>
> > > > > > > Date: 2008/07/25 Fri AM 10:18:46 PDT
> > > > > > > To: Asterisk Repeater Controler <app_rpt at lists.illiana.net>
> > > > > > > Subject: [App_rpt] General config questions....try #2
> > > > > > > 
> > > > > > > 
> > > > > > > Hi Everyone,
> > > > > > > 
> > > > > > > Since I haven't heard any feedback about this post, I guess 
> > > > > > > the answer is "no" to these questions??? ....If so, I think 
> > > > > > > I'll have a go at resolving them.
> > > > > > > 
> > > > > > > Thanks!
> > > > > > > 
> > > > > > > David KB4FXC
> > > > > > > 
> > > > > > > 
> > > > > > > Original message:
> > > > > > >
> 
> > > > > > > Now that I'm to the "beta" test phase, I've got some more 
> > > > > > > questions that I don't see answers to on the list--or have
> overlooked (if so, oops!).
> > > > > > >
> 
> > > > > > > First, is there an easy way to disable DTMF decoding 
> > > > > > > entirely for a channel? My HF node (on very staticy 75M) 
> > > > > > > generates a fair number of spurious DTMF decodes. And, each 
> > > > > > > time it thinks it hears a code, there is, as expected, a 
> > > > > > > very short dropout of HF RX audio being passed to the UHF 
> > > > > > > repeater side. I don't need DTMF decode at all for this node and
> would like to turn it off.
> > > > > > >
> 
> > > > > > > Second, does anyone have (or know of) a simple utility to 
> > > > > > > generate sound files for the CD ID, etc.
> > > > > > >
> 
> > > > > > > Thanks!
> > > > > > >
> 
> > > > > > > David KB4FXC
> > > > > > > 
> > > > > > > 
> > > > > > > _______________________________________________
> > > > > > > App_rpt mailing list
> > > > > > > App_rpt at lists.illiana.net
> > > > > > > http://lists.illiana.net/mailman/listinfo/app_rpt
> > > > > > > 
> > > > > > 
> > > > > > _______________________________________________
> > > > > > App_rpt mailing list
> > > > > > App_rpt at lists.illiana.net
> > > > > > http://lists.illiana.net/mailman/listinfo/app_rpt
> > > > > 
> > > > 
> > > > _______________________________________________
> > > > App_rpt mailing list
> > > > App_rpt at lists.illiana.net
> > > > http://lists.illiana.net/mailman/listinfo/app_rpt
> > > 
> > 
> > _______________________________________________
> > App_rpt mailing list
> > App_rpt at lists.illiana.net
> > http://lists.illiana.net/mailman/listinfo/app_rpt
> > 
> 
> _______________________________________________
> App_rpt mailing list
> App_rpt at lists.illiana.net
> http://lists.illiana.net/mailman/listinfo/app_rpt
> 
> _______________________________________________
> App_rpt mailing list
> App_rpt at lists.illiana.net
> http://lists.illiana.net/mailman/listinfo/app_rpt
> 




More information about the App_rpt-users mailing list