[App_rpt-users] Greetings and found a bug in app_rpt.c

[hwstar at rodgers.sdcoxmail.com]

> 
> From: Mike <mike at microdel.org>
> Date: 2010/08/12 Thu AM 09:05:56 PDT
> To: app_rpt-users at qrvc.com
> Subject: [App_rpt-users] Greetings and found a bug in app_rpt.c
> 
> I'm a new allstar user and have been testing a stand alone simplex node
> for a few weeks now.  Kudos to all involved in the development of this
> great system!
> 
> My system is in "Simplex Dumb Phone Control mode".  From the comments in
> app_rpt.c the (*) key is supposed to toggle the transmitter and the (#)
> key is supposed to turn the transmitter off.  In fact what I found was
> that any DTMF key turned the transimtter on and both (*) and (#) toggled
> it.  After realizing this was not likely a configuration issue, believe
> me I tried MANY combinations, I started perusing the source.
> 
> Turns out changing line 16607 in app_rpt.c as follows fixes this issue.
> 
> From:
>                  else if (keyed && !*keyed && (c = myrpt->p.funcchar))
> To:
>                  else if (keyed && !*keyed && (c == myrpt->p.funcchar))
> 
> Obviously the intent is to test for equality not assign 'c' a new value.
> 
> Not sure if this is the right place to report this, if not hopefully
> someone will point me in the right direction.
> 
> -- Thanks, Mike KB7XP
> _______________________________________________
> App_rpt-users mailing list
> App_rpt-users at qrvc.com
> http://qrvc.com/mailman/listinfo/app_rpt-users
> 

This needs to be fixed. Please create a mantis account
on mantis.qrvc.com and report the bug there. This way,
it won't get lost in the thread here.

Steve
WA6ZFT