[App_rpt-users] Greetings and found a bug in app_rpt.c

[Mike]

I'm a new allstar user and have been testing a stand alone simplex node
for a few weeks now.  Kudos to all involved in the development of this
great system!

My system is in "Simplex Dumb Phone Control mode".  From the comments in
app_rpt.c the (*) key is supposed to toggle the transmitter and the (#)
key is supposed to turn the transmitter off.  In fact what I found was
that any DTMF key turned the transimtter on and both (*) and (#) toggled
it.  After realizing this was not likely a configuration issue, believe
me I tried MANY combinations, I started perusing the source.

Turns out changing line 16607 in app_rpt.c as follows fixes this issue.

From:
                 else if (keyed && !*keyed && (c = myrpt->p.funcchar))
To:
                 else if (keyed && !*keyed && (c == myrpt->p.funcchar))

Obviously the intent is to test for equality not assign 'c' a new value.

Not sure if this is the right place to report this, if not hopefully
someone will point me in the right direction.

-- Thanks, Mike KB7XP